Skip to content

chore: fix JavaScript lint errors (issue #8208 and #8140) #8223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

chore: fix JavaScript lint errors (issue #8208 and #8140) #8223

wants to merge 1 commit into from
+21 −21

Conversation

morijvan
Copy link

@morijvan morijvan commented Oct 8, 2025 •
edited
Loading

Resolves #8208. #8140.

Description

This pull request fixed lintint errors in:

Resolves #8208.

        -  etc/eslint/rules/stdlib.js
        -  .github/workflows/lint_changed_files.yml
        -  .github/workflows/lint_random_files.yml 
            by removing extra space and unused ESLint disable directive.

Resolve #8140.

        -  lib/index.js
            by removing file path.

Related Issues

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Why this approach

I faced issue while working with the index.js file in my stdlib library. The project kept showing an error like “Cannot find module './main.js'”.
After checking the code, I realized the problem was in the file path — the entry point wasn’t properly referencing the main file or the file was placed incorrectly.

To solve this, I reviewed the folder structure and updated the path to a correct relative one:

     const stdlib = require('./main.js');
     module.exports = stdlib;

Once I fixed the path and confirmed that main.js was in the same directory, everything started working perfectly.

Now, the index.js acts as the main entry point for the library, and I can easily import it using:

     const stdlib = require('@stdlib/stdlib');

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Oct 8, 2025
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot
Copy link
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Gitter channel to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Potential Duplicate There might be another pull request resolving the same issue. labels Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review. Potential Duplicate There might be another pull request resolving the same issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors Fix JavaScript lint errors

2 participants

@morijvan @stdlib-bot